Block Bindings: Make core/post-data source code more semantic
#73394
+52
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Code Quality
ockham
changed the title
core/post-data source code more semantic
|
Size Change: -18 B (0%) Total Size: 2.51 MB
ℹ️ View Unchanged
|
This reverts commit ba8ad02.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
commented
Nov 19, 2025
Comment on lines
-95
to
-110
|
|
||
| it( 'should return empty object for unknown fields', () => { | ||
| const values = postDataBindings.getValues( { | ||
| select, | ||
| context: { postId: 123, postType: 'post' }, | ||
| bindings: { | ||
| content: { | ||
| source: 'core/post-date', | ||
| args: { field: 'unknown' }, | ||
| }, | ||
| }, | ||
| clientId: '123abc456', | ||
| } ); | ||
|
|
||
| expect( values.content ).toEqual( {} ); | ||
| } ); |
Contributor
Author
There was a problem hiding this comment.
This test case was merged into the two test cases above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Make Block Bindings
core/post-datasource code (and unit tests) yet more semantic.This PR also changes the source's behavior slightly:
core/post-metasource.postIdorpostTypearen't provided via context,getFieldsListwill now return an empty array. The idea is that the return value ofgetFieldsListis used to populate the dropdown of available source items for a given block. However, if there's nopostIdorpostTypeinformation available (which can be the case e.g. in a taxonomy term template), we don't want to show any items from thecore/post-datasourceWhy?
I think it's still unclear how a source's
getValuesandgetFieldsListfunctions are supposed to behave, e.g. in absence of required data, and what fallback values they are supposed to provided. A lot of that information is currently still buried in fairly subtle/implicit fallbacks mechanisms (e.g. via optional chaining). This PR seeks to make the expected behavior more explicit.How?
Some refactoring, and additional test coverage.
Testing Instructions
Verify that tests pass. Bonus points for some light smoke testing. (Use the Date block's "Post Date" and "Modified Date" variations and verify that they work as expected.)