Fix react/jsx-runtime import in built files #73391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
added
the
[Type] Build Tooling
Member
|
Nice, I didn't realize we had already adopted the |
Member
Author
This needs to be tested against a few major codebases via local package linking. I am planning to do so for Jetpack. People may try the same for any other large codebases. |
manzoorwanijk
requested review from
a team,
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
draganescu,
ellatrix,
fabiankaegy,
gigitux,
gziolo,
kevin940726,
nerrad,
ntsekouras,
ntwb,
oandregal,
peterwilsoncc,
ryanwelcher and
talldan
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +69 B (0%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
Contributor
|
For me this feels like a regression. We want to move away more from |
youknowriad
reviewed
Nov 18, 2025
| const emotionPlugin = babel( { | ||
| filter: /\.[jt]sx?$/, | ||
| config: { | ||
| presets: [ |
Contributor
There was a problem hiding this comment.
This is restores a behavior that we abandoned before. So I don't really think that this is the right path forward.
Member
Author
Then I think #73258 is the right approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #73257 and an alternative to #73258 as discussed in #73258 (comment)
Ideally, the consumer packages should never really need to install
reactorreact-domas a dependency, nor should we mention it as a peer dependency because all of our react packages use@wordpress/elementas a dependency. But, our build output contains jsx import fromreact/jsx-runtimewhich causes build issues for the consumer build tools.What?
Closes
Why?
How?
/jsx-runtimeand/jsx-dev-runtimesub-paths from the element packagejsx-runtimefrom@wordpress/elementTesting Instructions
npm run buildreact/jsx-runtimeTesting Instructions for Keyboard
Screenshots or screencast