Conversation
youknowriad
added
the
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Nov 18, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes SCSS file changes in dependencies not being reflected in dependent packages during watch mode.
Why?
When editing SCSS files in one package (e.g.,
global-styles-ui), packages that import the compiled CSS from that package'sbuild-style/directory (e.g.,edit-site) weren't automatically rebuilding. The watch mode was only rebundling scripts but not recompiling styles for dependent packages.How?
Added
compileStyles()call for affected packages before rebundling them in watch mode. This ensures CSS is recompiled for all packages that depend on the changed package.Testing Instructions
npm run devpackages/global-styles-ui/src/style.scssand savepackages/edit-site/build-style/style.cssis automatically updatededit-site/src/style.scssis neededCloses #73373