-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add Overlay template part area behind Experiment #73359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d8811f6 to
1a1451a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +160 B (+0.01%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
scruffian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify "Overlays" appears in the template parts list (before "General")
Just noting that this only appears when overlays already exist.
Apart from this, everything looks good
|
Annoyingly this is forcing me towards needing to raise a Core ticket to track the need for a backport. But I"m not ready to commit to this as it's an experimental feature. |
1032bf2 to
2cc8a14
Compare
What
Adds support for a new "Overlay" template part area type, enabling users to create and design custom mobile navigation overlays as reusable template parts. This work is part of #73079 and focuses solely on the template part area registration infrastructure.
The overlay area is gated behind the
gutenberg-customizable-navigation-overlaysexperiment flag.Why
This provides the foundation for customizable navigation overlays by allowing users to create overlay template parts. Making overlays template parts gives both users and theme authors flexibility to define bespoke mobile navigation experiences. This work establishes the template part area infrastructure needed before the Navigation block can select or assign custom overlays (which will be handled in #73080).
How
Registers the "Customizable Navigation Overlays" experiment flag (re-implementing what was in PR Add experiment flag for Customizable Navigation Overlays #73356)tableColumnAfteras a placeholder)The overlay area uses
tableColumnAftericon as a placeholder (with TODO comments) until a proper overlay icon is available.Testing Instructions
window.__experimentalNavigationOverlaysis set totruein browser console