Accordion Block: Trigger panel opening from URL hash or anchor link #73357
+302
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +251 B (+0.01%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
Contributor
Author
|
In my testing, this PR works fine, but I'm not sure whether it should be backported to 6.9 🤔 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
mikachan
approved these changes
Nov 18, 2025
Member
mikachan
left a comment
mikachan
left a comment
There was a problem hiding this comment.
This is testing well for me, nice work!
- When using
#anchor-1, first accordion panel opens and scrolls to the contents inside ✅ - When using
#anchor-2, second accordion panel opens and scrolls to the contents inside ✅ - Clicking on a link to
#anchor-1correctly scrolls where expected ✅ - Inserting two more anchor links to the same post also works as expected ✅
Thanks for adding tests, as well 🙇
but I'm not sure whether it should be backported to 6.9
I'm also not sure; this is one of those PRs that would be great to include, but isn't necessarily fixing a critical bug. For what it's worth, I don't think it's high risk to include, and I think it's a big improvement on the current behaviour, so I'd be in favour of backporting it. But not strongly opinionated!
Contributor
Author
|
@mikachan Thanks for the review!
Well, since the Accordion block is first released in 6.9 and this PR has a predictable scope, let's backport it to 6.9. @luisherranz @DAreRodz, just to be sure, I'll leave this PR open this week and plan to merge it before the RC3 release next week. If you have any concerns about backporting it to 6.9, please let us know. |
t-hamano
added
the
Backport to WP 6.9 Beta/RC
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
t-hamano
added
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 24, 2025
…73357) Co-authored-by: t-hamano <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: bph <[email protected]> Co-authored-by: hagege <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 399892e |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 25, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. * [Fix isNewLink value with entity binding (#73368)](WordPress/gutenberg#73368) * [Unit testing: Allow Composer to auto-detect PHP version (#73358)](WordPress/gutenberg#73358) * [Move the Edit Navigation button to the last item in the block toolbar to ensure that the styling is consistent and simple (#73436)](WordPress/gutenberg#73436) * [Block Support: Change block visibility support key (#73432)](WordPress/gutenberg#73432) * [Accordion: add box-sizing:border-box rule (#73507)](WordPress/gutenberg#73507) * [Accordion Block: Trigger panel opening from URL hash or anchor link (#73357)](WordPress/gutenberg#73357) * [iAPI: Backport of "Return a deep-clone object from `getServerState` and `getServerContext` functions" (#73514)](WordPress/gutenberg#73514) * [Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module (#72489) (#73512)](WordPress/gutenberg#73512) * [Accordion Item: Don't use grid layout (#73501)](WordPress/gutenberg#73501) * [Drag and drop: remove grab cursor for multi-selection (#73521)](WordPress/gutenberg#73521) * [Math block: fix accessibility (#73508)](WordPress/gutenberg#73508) * [iAPI: Fix using `getServerContext` in derived state getters (#73518) (#73531)](WordPress/gutenberg#73531) * [Drag: hide block tools popovers (#73539)](WordPress/gutenberg#73539) Developed in #10549. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Props priethor. See #64301. git-svn-id: https://develop.svn.wordpress.org/branches/6.9@61304 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 25, 2025
Changes can be found at https://github.com/WordPress/gutenberg/commits/wp/6.9/. * [Fix isNewLink value with entity binding (#73368)](WordPress/gutenberg#73368) * [Unit testing: Allow Composer to auto-detect PHP version (#73358)](WordPress/gutenberg#73358) * [Move the Edit Navigation button to the last item in the block toolbar to ensure that the styling is consistent and simple (#73436)](WordPress/gutenberg#73436) * [Block Support: Change block visibility support key (#73432)](WordPress/gutenberg#73432) * [Accordion: add box-sizing:border-box rule (#73507)](WordPress/gutenberg#73507) * [Accordion Block: Trigger panel opening from URL hash or anchor link (#73357)](WordPress/gutenberg#73357) * [iAPI: Backport of "Return a deep-clone object from `getServerState` and `getServerContext` functions" (#73514)](WordPress/gutenberg#73514) * [Reuse wp_script_attributes filter for adding data-wp-router-options attribute to script module (#72489) (#73512)](WordPress/gutenberg#73512) * [Accordion Item: Don't use grid layout (#73501)](WordPress/gutenberg#73501) * [Drag and drop: remove grab cursor for multi-selection (#73521)](WordPress/gutenberg#73521) * [Math block: fix accessibility (#73508)](WordPress/gutenberg#73508) * [iAPI: Fix using `getServerContext` in derived state getters (#73518) (#73531)](WordPress/gutenberg#73531) * [Drag: hide block tools popovers (#73539)](WordPress/gutenberg#73539) Developed in WordPress/wordpress-develop#10549. See https://make.wordpress.org/core/handbook/about/release-cycle/block-editor-release-process-for-major-releases/#package-updates-and-core-patches. Props priethor. See #64301. Built from https://develop.svn.wordpress.org/branches/6.9@61304 git-svn-id: http://core.svn.wordpress.org/branches/6.9@60616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72685
What?
If the target triggered by the following action is contained within an Accordion panel, open the panel and scroll to the target element:
Why?
Unless the panel containing the element is automatically opened, the user will not be able to visually see the element when the link is clicked.
How?
Add a new
openPanelByHashaction. This action is executed when the accordion item is initialized or when the hash is changed.Additionally, I've added some basic E2E tests.
Testing Instructions
Use the following HTML to insert an Accordion block. This Accordion block consists of two Accordion Item blocks and has "Auto close" enabled:
#anchor-1to the end of the URL.#anchor-1and add#anchor-2to the end of the URL.#anchor-1in some of the text.Screenshots or screencast
8634dc471a6f929ad99dde41d573a72e.mp4