Framework: Sync lockfile changes under Node.js v24 build#73314
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
the
[Type] Task
|
Size Change: +2.34 kB (+0.09%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5846ae9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19375951280
|
Member
Contributor
|
Totally my fault, I did try to use |
senadir
approved these changes
Nov 14, 2025
Contributor
senadir
left a comment
senadir
left a comment
There was a problem hiding this comment.
Both node 20 and 24 produce no changes to the lock
Member
Author
Yeah another solution to this problem is ensuring that we use a consistent version of NPM regardless which Node.js version we have installed (see #72143). |
Member
Author
Node.js v20 is the default, so it's not your fault, this is an easy thing to miss. It's just that the version of NPM that comes with Node.js v24 (which we only run on |
bph
added
[Type] Build Tooling
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates
package-lock.jsonto commit changes after runningnpm installwith the version of NPM shipped with Node.js v24.Follow-up to #72703
Related to #72143
Why?
Fix build failures on
trunkExample: https://github.com/WordPress/gutenberg/actions/runs/19374127875/job/55437158928
How?
Commit changes produced after switching to Node.js v24:
Testing Instructions
Verify that no changes are produced to
package-lock.jsonin both Node.js v20 and v24: