Merged
Conversation
|
Size Change: +6.33 kB (+0.26%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/template-part-route
branch
from
34a2b4d to
183f2b8
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
add/template-part-route
branch
from
183f2b8 to
e39b25d
Compare
Contributor
|
It works! I assume the 'Add' button isn't supposed to do anything at this stage? |
Contributor
Author
|
@jameskoster forgot about the add button, let me check :) |
Contributor
Author
|
I fixed the add button. |
Contributor
|
I can't speak to the code but it works 😄 |
Contributor
Author
|
It's the best code ever :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #70862
What?
This PR implements the template part route (separate from patterns) into the new Gutenberg-boot routing based site editor.
This follows the designs proposed in #73251
There's a lot of small details missing but the goal for me now is to embrace iterations, get the big of the work done and once we get close to parity with the site editor, audit each page deeply and add/polish all the details.
Testing Instructions
http://localhost:8888/wp-admin/admin.php?page=gutenberg-boot&p=%2Ftemplate-parts%2Flist%2Fall