Template activation: move to experiment #73252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
No Core Sync Required
|
Size Change: +2.76 kB (+0.11%) Total Size: 2.51 MB
ℹ️ View Unchanged
|
ellatrix
requested review from
kevin940726,
nerrad and
spacedmonkey
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Nov 18, 2025
| @@ -1,5 +1,52 @@ | |||
| <?php | |||
|
|
|||
| // Migrate existing "edited" templates. By existing, it means that the template | |||
Contributor
There was a problem hiding this comment.
Since this is not landing in wordpress-6.9, should we move all the related files to 7.0
Contributor
|
I disabled the experiment, I still see activate/deactivate actions 
|
Contributor
|
I wonder also if we had the "duplicate" action before or if we added it as part of this work? |
Contributor
This field need to be removed as well I think |
Contributor
This one probably as well. |
Contributor
|
@ellatrix wait forget the previous feedback, It's all good now but I swear something enabled the experiment after I disabled it explicitly. |
ellatrix
force-pushed
the
move/template-activate-experiment
branch
from
68cefc3 to
091420a
Compare
Contributor
|
Ok here's what happens for me:
It is possible that is due to the fact that I also have WP 6.9 running. I believe we need to avoid the auto re-enabling somehow. |
Contributor
|
Looks like I have WP 6.9 beta 1, so maybe not something that need fixing since newer betas/RC don't include template activation. |
Contributor
|
Other than that auto-switching issue, it's all good for me. |
Member
Author
The auto-switching is for 6.9-beta and not something we should fix right? |
Contributor
Yeah, I think it's less important that I thought originally, It might impact some folks though, so I wonder if there's an easy fix, if not, maybe it's ok to ship as is. |
Member
Author
|
I'm a bit confused when the auto-switching happens. You're referring to this right? Does this also happen outside of 6.9-beta? Or which people might be impacted? |
Contributor
|
I don't know if it happens outside 6.9 beta, since I only tested on 6.9 beta 1. My guess is it doesn't. But I was thinking that some folks might be running these broken 6.9 beta versions with Gutenberg with no? (could be an insignificant number though) |
Member
Author
|
@youknowriad Hm, I'm not sure how would would disable the code that 6.9-beta has? They'd just have to upgrade to 6.9-rc? And yes, the experiment will be on there, as expected. They should de-duplicate the templates and then untoggle the experiment |
mcsf
approved these changes
Nov 18, 2025
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Tested well for me. While an intimidating patch at first, it reads well and makes sense. Nice work! Let's merge and 🤞.
| value="1" | ||
| <?php checked( 1, gutenberg_is_experiment_enabled( 'active_templates' ) ); ?> | ||
| /> | ||
| <?php echo __( 'Allows multiple templates of the same type to be created, of which one can be active at a time.', 'gutenberg' ); ?> |
Contributor
There was a problem hiding this comment.
No action needed here, but reading this line makes me think that all/most experiments ought to have links to, at the very least, an issue or PR.
Member
Author
There was a problem hiding this comment.
Hm, that's a good idea. Should I add a link here?
Member
Author
There was a problem hiding this comment.
Added a link to the original issue
ellatrix
added
the
Backport to Gutenberg RC
|
Flaky tests detected in a8946b0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19473173687
|
ellatrix
added a commit
that referenced
this pull request
Nov 18, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mcsf <[email protected]>
cbravobernal
pushed a commit
that referenced
this pull request
Nov 19, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: mcsf <[email protected]>
Contributor
|
I just cherry-picked this PR to the release/22.1 branch to get it included in the next release: ebbc859 |
cbravobernal
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We need to look through #73025 and make sure we wrap everything is conditions and otherwise restore the old code. Basically we want both versions at the same time. I've also restored the old e2e test file, and we should keep the current one as well.
One issue: when you start duplicating and create multiple of the same template, the old system might get confused about which template is active. Generally we don't really want people to switch between these experiments as it's hard to migrate back.
Perhaps we should delete all newly created templates? But that would be content loss. Maybe we should disallow unchecking the experiment and put a big warning before enabling? IDK.What I went for in the end is warn about toggling it off. People should make sure they don't have any templates other than active ones.
Why?
We need some more time to make template activation work well UI wise.
How?
For anyone who has a version of GB where template activation was active, we auto-enable the experiment.
Testing Instructions
Toggle the experiment on/off. If you earlier had GH trunk, it will already be on.
Testing Instructions for Keyboard
Screenshots or screencast