Breadcrumbs: Add attachment handling
#73249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
changed the title
attachment handling
|
Size Change: +7 B (0%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Nov 14, 2025
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
Left comments, but LGTM.
While we're here, could you label the screenshots in the PR description, so that we can tell which is core and which is x3p0?
ntsekouras
force-pushed
the
breadcrumbs-handle-attachments
branch
from
317a17e to
006954d
Compare
|
Flaky tests detected in 006954d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19364242339
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #72498
This PR adds
attachmenthandling. The code handles other custom post types similar toattachmentsthat are not hierarchical, but have values inpost_parent.Testing Instructions
wp_attachment_pages_enabledsetting to1. Save changes.View attachment pageScreenshots or screencast
Below I'm sharing some screenshots in a site that I've added x3p0-breadcrumbs plugin and the core block in the main header.
Above is x3p0-breadcrumbs and below is the core block.
With terms
With ancestors
No parent (upload in media library)