DataViews: Only apply hover styles when there are bulk actions #73248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] DataViews
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @cre8tivediva. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +58 B (0%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 13, 2025
| } | ||
|
|
||
| // Hover styles only apply when bulk actions are available | ||
| &.has-bulk-actions { |
Contributor
There was a problem hiding this comment.
What if we remove the hover styles entirely, and only select the item when you actually click the checkbox?
Contributor
Author
There was a problem hiding this comment.
I think that's worth exploring, but probably separately. It might be considered a regression given the reduction in target size, especially as checkboxes are already too small. Some relevant discussion in:
Contributor
There was a problem hiding this comment.
Ok, sounds good to me.
Contributor
There was a problem hiding this comment.
I do think it's not a regression though, it makes things clearer:
- checkboxes are for selecting the item.
- clicking the main "title field" is for the main action of the table.
- the rest is just a regular html table.
youknowriad
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65009
What?
As title :)
Why?
The hover styles make the row appear interactive which can be misleading.
How?
hasBulkActionsis true, the table gets thehas-bulk-actions class.has-bulk-actionsclass.Testing Instructions
npm run storybook