Make DataViews table checkbox permanently visible #73245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: -173 B (-0.01%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Nov 14, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM!
Just to be sure, we're not planning on changing the behavior of checkboxes in grid layout, right? If we need to make similar changes to grid layout, we'll need to update this here:
gutenberg/packages/dataviews/src/dataviews-layouts/grid/style.scss
Lines 125 to 141 in 07c8f83
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @madebynoam, @JanaMW27. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
I wouldn't object to changing grid layout as well, but I think the issue is less pronounced there because grid layout is less suited to bulk actions compared to table layout. Worth exploring in a separate PR I reckon. |
|
Contributor
Author
|
@madebynoam ah I could have worded that better. The logic to include checkboxes based on the presence of bulk actions already exists. This PR just ensures they're always visible. |
Got it. Thank you, @jameskoster! |
oandregal
approved these changes
Nov 17, 2025
Contributor
Author
|
I'm going to merge this. There's plenty of time to test during the 7.0 cycle and we can easily revert if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59175
What?
Make checkboxes in DataViews table layout permanently visible (assuming bulk actions are available)
Why?
See #59175.
Testing Instructions
npm run storybook.Before
After