Reuse mediaUpload filter for new media modal by wrapping it in a class component #73225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
adamziel,
draganescu,
ellatrix and
kevin940726
as code owners
tellthemachines
added
[Feature] Media
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -322 B (-0.01%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
Contributor
|
While I think this is reasonable as a next step, we're working towards upgrading to React 19 at some point. and this means no class components, this won't be the only place impacted though. |
Member
React 19 hasn't dropped class components, but yeah, it looks like they're urging folks to migrate to function components so future-proofing is a good call. What's the alternative for backwards compatibility? Is there a shim that makes a functional component work with Do filter callbacks like Otherwise, assuming that we can't update every plugin that requires class extension, what about a deprecation notice? |
Contributor
We probably need to deprecate that behavior, it's not really clear why we require these components to be class components. |
Contributor
Author
Some plugins are extending the MediaUpload class component through the I think that in order to avoid creating a new filter, we could just wrap this in a class for now and perhaps add a deprecation notice or something? |
Contributor
Yes, this works for me. |
Contributor
Author
|
Deprecation notice added! This is now ready for a final review. |
andrewserong
approved these changes
Nov 17, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Looking good, this feels much tidier 👍
Testing well with the AMP plugin active, with and without the experiment, using image, audio, file blocks in the post and site editors, and setting featured images.
LGTM! 🚢
| 'core/editor/components/media-upload', | ||
| () => { | ||
| deprecated( 'Extending MediaUpload as a class component', { | ||
| since: '19.9', |
Contributor
There was a problem hiding this comment.
Oh, whoops, missed this while testing. Should this be 6.9?
Or, since 7.0 with deprecated in 7.2? (I.e. which version will be deprecating in, and which version will it be removed)
Contributor
Author
There was a problem hiding this comment.
Oh that number's way off, it was meant to be Gutenberg release 😅 but yeah it makes more sense for it to be core version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #71944, on @youknowriad 's suggestion: we should be able to reuse the
editor.MediaUploadfilter for the experimental media upload modal as long as we wrap it in a class component to avoid the kind of breakage addressed in #70648.I tested this by installing the AMP plugin and switching the class wrapper in this PR to a function. The image block I was testing with errored. I then switched back to the class wrapper and all worked well.
I didn't test with any other plugins; I'm not sure which others may be expecting a class component here. If anyone knows of other plugins to test with, please leave a comment here!
Testing Instructions