WP_Theme_JSON: deprecate is_safe_css_declaration() and replace with is_safe() #73224
Closed
WP_Theme_JSON: deprecate is_safe_css_declaration() and replace with is_safe() #73224
Conversation
…larations_Gutenberg::is_safe() method - Replaced static::is_safe_css_declaration() calls with the new is_safe() method for improved safety checks. - Updated related tests to validate the new method's functionality and edge cases. - Marked the old is_safe_css_declaration() method as deprecated.
ramonjd
changed the title
Member
Author
|
Going back to the drawing board on these changes, I think a broader CSS validation/sanitization strategy is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Part of #65728
Similar to
#73117
Refactor CSS declaration safety checks to use WP_Style_Engine_CSS_Declarations_Gutenberg::is_safe() method
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast