Try enabling paragraphs to be added to contentOnly patterns #73222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Experimental
|
Size Change: +68 B (0%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
4 tasks
Contributor
|
I can't quite get it to work, but at a high level it seems like being able to press Enter inside a pattern-locked paragraph to still allow you to create another, would work, and arguably be better than the present alternative that creates br tags. Thanks for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses #71887.
Just playing around for now. This PR adds checks to
canInsertBlockTypeUnmemoizedandcanRemoveBlockto enable adding/removing Paragraph blocks in contentOnly patterns where other Paragraph blocks already exist.It sort of works, but doesn't always work. Maybe in investigating why this doesn't always work we can come up with a better solution 😄
Testing Instructions