Patterns: Add pattern name to document toolbar when editing in spotlight #73208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
added
[Type] Enhancement
|
Size Change: +410 B (+0.02%) Total Size: 2.54 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Nov 18, 2025
|
|
||
| // Use pattern info if a pattern block is unlocked, otherwise use document/entity info | ||
| const title = | ||
| unlockedPatternInfo?.patternTitle || |
Member
There was a problem hiding this comment.
This is a great change, I like!
Should it work for synced patterns and "templateLock":"contentOnly" blocks as well? Both receive content only treatment.
Member
There was a problem hiding this comment.
Should it work for synced patterns and "templateLock":"contentOnly" blocks as well?
Not sure about those, but I updated this PR to work with synced patterns and template parts. Hope you don't mind!
…oved section detail retrieval - Removed inline logic for fetching details of the currently edited content-only section. - Added a new custom hook, useEditedSectionDetails, to encapsulate the logic for retrieving pattern and template part details. - Updated DocumentBar to utilize the new hook for cleaner and more maintainable code.
ramonjd
force-pushed
the
add/pattern-name-to-document-toolbar
branch
from
da9c72d to
9c6ab9c
Compare
ramonjd
approved these changes
Nov 26, 2025
Member
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
This is behind an experiment. It works as it should.
blocks with templateLock are currently not catered for but that can be a follow up if it's at all necessary.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a contentOnly pattern is being editing in the canvas, we should show the pattern name and a back button in the document toolbar.
Why?
This tells the user that they are editing a pattern, and gives them a mechanism to finish editing.
Alternative to #73088
How?
Updates the document toolbar to detect when a pattern is being edited.
Testing Instructions
Screenshots or screencast
Kapture.2025-11-26.at.11.38.02.mp4