The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: sejas <[email protected]>
Co-authored-by: strarsis <[email protected]>
Co-authored-by: Thelmachido <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: danielbachhuber <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Size Change: +122 B (+0.01%)

Total Size: 2.41 MB

_{compressed-size-action}

Flaky tests detected in 7cc597c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19327010834
📝 Reported issues:

• [Flaky Test] ensures List View global shortcut works properly #51533 in /test/e2e/specs/editor/various/list-view.spec.js

I added the warning but to be honest, I'm not convinced, why add a feature that shows a warning on each use.

To me, this is no different than a failling contrast, to answer the "why". It's also shown in a set-it-and-forget-it-context, so you won't see it that often.

If it helps, you can change it from warning to info, to make it more neutral looking. We can also reduce the text. Perhaps:

Note: Justified text can reduce readability. For better accessibility, use left-aligned text instead.

To me, this is no different than a failling contrast

It's different in the sense that failing contrast is not something you turn on and off, you can change colors and that's it. Here it's for everyone using it, one might argue that we should just not have it.

My understanding is that the justify option is needed in the first place because it may be used in some industries (publishers, schools, etc.). Is that correct?

It's different in the sense that failing contrast is not something you turn on and off, you can change colors and that's it. Here it's for everyone using it, one might argue that we should just not have it.

That's why justified text is not available for the Paragraph block outside of global styles.

However the use case for justified text still makes sense as a global set-and-forget toggle, because some newsrooms have strict editorial guideliens that require justified text. And some school assignments might require it. In those cases we want to be able to provide it as an option, but just with the proper note that it affects legibility.

If there are such requirements for justified text, whatever the context might be, we also want to avoid having it in the paragraph block dropdown, and require you to adjust it globally, because we want to avoid you having to edit every post on your site, paragraph by paragraph, to justify them. Just like RTL alignment for eastern languages, it's a set it and forget it change that should be done once, and for that context it feels useful enough to me to have text that explains the purpose.

A 3rd option beyond what we have now, is to treat this more like help text. Just like we have contextual help text for drop cap, we could have contextual help text for each of the four alignments:

Or we could have helptext that appears only for justified text, same gray-small-text treatment. Any preference?

A help text that appears for a specific value is very similar to what we have with the warning, so let's start with that and see.

I was not arguing for removing the feature btw, my preference would be to not have a warning in the first place because there are valid use-cases.

I don't have a strong opinion about the warning itself, but I prefer help text.

I was not arguing for removing the feature btw, my preference would be to not have a warning in the first place because there are valid use-cases.

There are valid use cases. But we just want to nudge you towards applying this feature only if you know what you are doing and really need it.