Routing: Add styles page as a route #73197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.08 kB (+0.09%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
Contributor
|
I can see a few errors in the console regarding blocks. For example Also it seems I cannot access the single page for posts lists when I click one. I guess you plan on adding a save button later on? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
reviewed
Nov 13, 2025
| </div> | ||
| ) } | ||
| { /* Render custom canvas when canvas() returns null */ } | ||
| { canvasData === null && CustomCanvas && ( |
Contributor
There was a problem hiding this comment.
Why do we also need canvasData === null and not directly check if CustomCanvas? Is this needed for routes to conditionally return either a custom canvas or use the default in some cases? If yes, what would be a case like that?
Contributor
Author
There was a problem hiding this comment.
Yes, and the stylebook is the use-case for it, because there will be an "eye" button to switch between stylebook and regular canvas.
Contributor
Author
|
I've seen the mathml issue before, I think it's unrelated with this PR and happens in the editor. I'll have to fix it separately. |
youknowriad
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
youknowriad
force-pushed
the
add/styles-page
branch
from
090a7a1 to
2d2b87b
Compare
Contributor
Author
Forgot about this, I'll add it now I think. |
Contributor
Author
This is fixed. |
|
Flaky tests detected in 23c10ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19327772189
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #70862
What?
This PR starts bringing features and pages from the site editor to routes. This starts with the styles page.
It also adds "custom canvas" support to the boot package to be able to render the stylebook in the canvas (as opposed to the regular default editor).
Testing Instructions
http://localhost:8888/wp-admin/admin.php?page=gutenberg-boot&p=%2Fstyles%3Fsection%3D%252F