DataForms: Update Email Control component to use envelope icon instead of a Symbol #73184
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @triple0t! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
triple0t
force-pushed
the
update/dataform-email-control-icon
branch
from
c481196 to
06828ab
Compare
|
Hi hi @oandregal @jorgefilipecosta, I'm creating this PR to start getting familiar with contributing upstream. Please let me know if you need anything from me. Thanks. |
jameskoster
left a comment
jameskoster
left a comment
There was a problem hiding this comment.
Approving the design change :)
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
Code-wise looks good as well!
oandregal
added
[Type] Enhancement
|
Thanks for your contribution @triple0t and congrats on your 1st merged Pull Request! |
bph
changed the title
3 participants
What?
Closes #73094
Updates the DataForm email control component to use an envelope icon instead of the
@symbol icon, providing a more conventional and recognizable visual indicator for email input fields.Why?
The current implementation uses an
@symbol (atSymbolicon) for email fields in DataForm, which is unconventional. The envelope icon is a more widely recognized and standard icon for representing email fields across user interfaces, improving user experience and interface consistency.How?
packages/dataviews/src/dataform-controls/email.tsxatSymboltoenvelopefrom@wordpress/iconsInputControlPrefixWrapperto render the envelope icon instead of the @ symbolTesting Instructions
Confirm email control icon is updated in http://localhost:50240/?path=/story/dataviews-dataform--layout-regular
Testing Instructions for Keyboard
N/A - This change only affects the visual icon display and does not modify keyboard interactions or accessibility features.
Screenshots or screencast