Hide toolbar slots for contentOnly pattern wrappers #73182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +35 B (0%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
Member
|
Thanks for getting this PR up so fast! Looking good for patterns, here's our beloved cover block in an unsynced pattern:
But it raises the question of what to do with template parts and synced pattern toolbars, which have "edit" links.
Is there a way to target patterns only 🤔 The only way I can think of is to check for the patterName metadata. |
Contributor
Author
Are those links in the same slot as the tools we want to hide? Maybe we can hide slots selectively. Edit: or maybe we can move the controls we want to preserve into their own slot. Edit 2: the controls we want to preserve are all in the "other" slot so I adjusted the condition to keep those visible. That also has the advantage of keeping the Cover "replace" control visible, which I believe we want. Edit 3: I also moved the reusable block controls into the "other" slot for consistency. |
tellthemachines
requested review from
ajitbohra and
fabiankaegy
as code owners
ramonjd
reviewed
Nov 12, 2025
| group="inline" | ||
| className="block-editor-block-toolbar__slot" | ||
| /> | ||
| { ! isSectionContainer && ( |
Member
There was a problem hiding this comment.
Nice idea!
Looking pretty good
Kapture.2025-11-12.at.14.17.38.mp4
I also checked unlocking patterns and "regular" blocks - toolbar items are there, but not when in content only mode.
|
Flaky tests detected in 9942cfd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19285059924
|
ramonjd
approved these changes
Nov 12, 2025
andrewserong
approved these changes
Nov 12, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Oh, I like the approach here, it feels nice and elegant to me, and it still preserves the section styles shuffle button:
The toolbar feels cleaner, but it's still possible for folks to change their alignment once they go in to unlock the design:
2025-11-12.15.29.39.mp4
I smoke tested a bit with and without the contentOnly experiment and playing around with template parts, etc, and all seemed to be working well.
LGTM too!
Contributor
Author
|
Thanks for reviewing folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #71553.
When patterns are in contentOnly mode their wrapper toolbars shouldn't show controls such as Align or Justify.
This PR hides the slots that contain those controls for section blocks, similarly to what already happens in zoom out mode.
Testing Instructions