-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ColorPicker: Support pasting whole color values #73166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests and it is nice improvement for advanced users when they discover it.
Yeah, this came to my mind too. We could try it if this goes well. :) |
403fe35 to
3748996
Compare
|
Flaky tests detected in 3748996. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19273841639
|
|
Great work! Thanks for working on this! Closes partially
I also had this idea in |
|
Hey, @hanneslsm! I think you accidentally referenced this very PR (73166). Which issue does this partially close? |
|
Oops, yes I did! That's the issue I was talking about: #50502 |

What?
When the ColorPicker is open, let the user paste a colour value in any recognisable format. No particular input needs to have focus: pasting works anywhere in the picker. This works even if the format isn't supported by the UI (internal representation is hexadecimal).
#123,rgb(100 200 30),hsl(60, 20%, 80%),cyancolorpicker-paste-1.mov
colorpicker-paste-2.mov
Why?
How?
Testing instructions