-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add: Stretch text variations transforms #73148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
In my opinion the transformations are a bit too busy. Could we at least move the transforms down to the next section and remove them from the document inspector heading? |
Hi @ellatrix, you mean creating a new section named transforms similar to the styles one? |
|
We are currently checking whether to backport this PR to 6.9, so let's add it to the project board just in case. |
|
@jorgefilipecosta No, I mean adding it to the second transforms section, below the line, next to Group, Code, Buttons etc. |
| const variations = [ | ||
| { | ||
| name: 'heading', | ||
| title: __( 'Heading' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding a heading variation? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is to allow the heading variation without fit text to appear at the side of stretchy text, otherwise the users would be able to transform to the stretchy text but have no way to transform back to the non stretchy version. It follows exactly the same pattern as Group.
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ellatrix <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: f9cc709 |
This reverts commit f9de048.
This reverts commit f9de048.
This PR readds the variations transforms for Stretchy Text variations which were tried at #73056 but ended not being part of what was merged.
The downside is that they are prominient but @ellatrix raised an important point the version that is currently merged does not allow to transform any existing block into their stretchy versions. Adding the transforms solves that using the same approach that allows a group the be transformed in a grid.
Screenshots