Math format: remove empty format on serialise #73143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6e88762. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19238273230
|
t-hamano
approved these changes
Nov 11, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I have confirmed that this pull request is working correctly.
Comment on lines
+34
to
+36
| const mathInput = page.locator( | ||
| '.block-editor-format-toolbar__math-input input' | ||
| ); |
Contributor
There was a problem hiding this comment.
Suggested change
| const mathInput = page.locator( | |
| '.block-editor-format-toolbar__math-input input' | |
| ); | |
| const mathInput = page.getByRole( 'textbox', { | |
| name: 'LaTeX math syntax', | |
| } ); |
Nit: This selector can be made more accessible.
Member
Author
There was a problem hiding this comment.
Thanks, I'll follow-up with a fix so that this definitely makes RC 1.
Mamaduka
reviewed
Nov 11, 2025
| await editor.clickBlockToolbarButton( 'More' ); | ||
| await page.getByRole( 'menuitem', { name: 'Math' } ).click(); | ||
|
|
||
| expect( await editor.getBlocks() ).toMatchObject( [ |
Member
There was a problem hiding this comment.
Suggested change
| expect( await editor.getBlocks() ).toMatchObject( [ | |
| await expect.poll( editor.getBlocks ).toMatchObject( [ |
It's better to use await expect.poll and async assertions, which benefit from auto-retries. The same applies to similar assertions in this file.
Member
Author
There was a problem hiding this comment.
I never got this. Why is it not ok to expect this to be correct immediately?
Member
There was a problem hiding this comment.
It's more like a safeguard or best practice. Most of the time, it's correct, and the test passes immediately, with no additional overhead. However, when it's not, the auto-retries are helpful to ensure that failure is actually related to not matching the object.
Member
There was a problem hiding this comment.
Not a blocker here. We can continue talking in the new PR.
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 11, 2025
Co-authored-by: ellatrix <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: c57fc49 |
|
Thanks for the PR. Tested as described and it works for me. |
Member
Author
Could you elaborate? I'm not quite understanding the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When adding inline math in rich text, and you dismiss it or empty it later, it leaves an empty math element.
Why?
This should not happen, we should remove it on serialization. This is similar to how there's no bold until there's content to bold.
How?
When an object in rich text is contenteditable and doesn't have content, don't serialize anything.
Testing Instructions
Add inline math to rich text. Don't write anything in the input. Then check the code editor, there shouldn't be a math element.
Also adds e2e tests for the math format generally.
Testing Instructions for Keyboard
Screenshots or screencast