Fix Navigation Link broken state when bound entity is deleted #73142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Block] Navigation
|
Size Change: +480 B (+0.02%) Total Size: 2.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b56680f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19236277282
|
getdave
commented
Nov 10, 2025
getdave
commented
Nov 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Navigation Link block to properly handle deleted entity bindings. When a linked Post/Page is deleted, the block now displays a clear error state with an actionable UI instead of remaining in a broken "partially bound" state.
Key Changes:
- Added entity availability detection to distinguish between valid bindings and deleted entities
- Implemented error state UI with clear messaging and one-click unsync functionality
- Auto-opens Link UI when deleted entity is detected to guide users toward fixing the issue
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
packages/block-library/src/navigation-link/shared/use-entity-binding.js |
Added entity availability checking via useSelect, introducing isBoundEntityAvailable and isBindingActive properties to distinguish between existing bindings with missing entities vs. active valid bindings |
packages/block-library/src/navigation-link/shared/controls.js |
Updated UI to show error state when entity is unavailable: empty input value, error message, enabled input with click-to-unsync functionality, and new MissingEntityHelpText component |
packages/block-library/src/navigation-link/link-ui/index.js |
Updated to use isBindingActive instead of checking binding metadata directly, ensuring Link UI only locks when binding exists AND entity is available |
packages/block-library/src/navigation-link/editor.scss |
Added CSS for error state styling, making the entire input clickable to trigger unsync when entity is missing |
packages/block-library/src/navigation-link/edit.js |
Enhanced useIsInvalidLink to detect deleted entities, added auto-clear URL and Link UI opening logic when deleted entity is detected on block selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This message only appears when the post/page is deleted permanently - should we also show it when the entity is in trash? |
Contributor
Author
It's a good question. We have a similar thing with For Trash I believe we show I think we should try as much as possible to limit the scope of this PR if it's got any chance of making 6.9. |
ellatrix
reviewed
Nov 11, 2025
| // Keep binding and ID so invalid state remains visible | ||
| setAttributes( { | ||
| url: undefined, | ||
| } ); |
Member
There was a problem hiding this comment.
Why do we need to clear the invalid URL? I don't love seeing effects that set attributes. What's the harm in keeping it?
Contributor
Author
There was a problem hiding this comment.
The whole effect wasn't needed.
Contributor
|
I noticed that the link gets removed when I click onto it and then off it: Screen.Recording.2025-11-11.at.09.24.12.mov |
ellatrix
added
the
Backport to WP 6.9 Beta/RC
Member
|
Adding the label so it gets more eyes. |
scruffian
reviewed
Nov 11, 2025
packages/block-library/src/navigation-link/shared/use-entity-binding.js
Outdated
Show resolved
Hide resolved
scruffian
reviewed
Nov 11, 2025
…ck-editor wasn't being mocked, causing a "is not a function" error.
Changes made to /Users/ben/Sites/gutenberg/packages/block-library/src/navigation-link/shared/test/use-entity-binding.js:
1. Added useBlockEditingMode to the @wordpress/block-editor mock (line 21)
2. Added mock for useSelect by mocking @wordpress/data/src/components/use-select specifically (lines 24-28), following the pattern used in other navigation tests
3. Set up default return values in beforeEach:
- useBlockEditingMode.mockReturnValue('default') (line 43)
- useSelect.mockReturnValue(true) (line 44)
The test "handles invalid kind gracefully in createBinding" now passes, along with all other tests in the file (17/17 passing).
scruffian
approved these changes
Nov 11, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
I think this is looking good now. Thanks for all your work on it.
Contributor
Author
I fixed this btw. |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch. PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk. |
ellatrix
added a commit
that referenced
this pull request
Nov 11, 2025
Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: ockham <[email protected]> Co-authored-by: ryanwelcher <[email protected]> Co-authored-by: t-hamano <[email protected]>
Member
|
Manually cherry-picked in d7dd02f. |
ellatrix
added
Backported to WP Core
Member
|
(I cherry-picked two bug fixes to the file that was causing conflicts.) |
This was referenced Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #72564
Fixes Navigation Link block to properly handle deleted entity bindings. When a Post/Page linked via dynamic binding is deleted, the block now shows a clear error state with actionable UI instead of a broken "part bound" state.
Why?
Previously, when a Navigation Link was bound to a Post/Page that was subsequently deleted, the link UI would display in a broken state:
This created a poor user experience where users couldn't understand why their link was broken or how to fix it.
How?
When a Navigation Link's bound entity is deleted:
In the Inspector Sidebar:
In the Canvas:
User Flow:
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2025-11-10.at.15-12-55.1.mp4