Pages DataViews: Fix content preview field after global styles refactor #73140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: -445 B (-0.02%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
Contributor
|
This fixed a bug I was seeing, thanks! There's no option to show the Featured image as the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
That was an unintended debugging change sorry I'll revert that part :) |
| * @param {string} path Style path (e.g., 'color.background') | ||
| * @param {string} blockName Optional block name | ||
| * @param {string} path Style path (e.g., 'color.background') | ||
| * @param {string=} blockName Optional block name |
Contributor
There was a problem hiding this comment.
Tiniest of tiny nits: is this meant to be a ?? (Same with the doc comment for useSetting)
Contributor
There was a problem hiding this comment.
Ah, ignore me, I just wasn't familiar with this syntax 😄
Contributor
Author
There was a problem hiding this comment.
no = is actually better because TS can understand that is optional. I think TS doesn't understand ?
Contributor
There was a problem hiding this comment.
Good to know, thanks! TIL
andrewserong
approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
I wasn't able to switch to the content preview manually (possibly related to this comment: https://github.com/WordPress/gutenberg/pull/73064/files#r2511053514) so hard-coded it in locally to test. LGTM 👍
jonathanbossenger
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #73139
What?
Fix the content preview field on pages dataviews. useGlobalStyle hook has been removed and was still being used in a field.