Notes: Add keyboard support for tree navigation #73136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
Size Change: +173 B (+0.01%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
t-hamano
commented
Nov 10, 2025
| test.describe( 'Keyboard navigation', () => { | ||
| test( 'should expand or collapse a comment with Enter key', async ( { | ||
| editor, | ||
| const KEY_COMBINATIONS = [ |
Contributor
Author
There was a problem hiding this comment.
Since there was already a test for expanding and collapsing notes using the Enter key, I extended it to also test the left and right arrow keys.
t-hamano
commented
Nov 10, 2025
| } | ||
| ); | ||
|
|
||
| test( 'should move to the adjacent comment with arrow keys', async ( { |
Contributor
Author
There was a problem hiding this comment.
The diffs are not showing well, but I simply added the following two new tests.
should move to the adjacent comment with arrow keysshould move to the first or last comment with Home or End keys
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 1add4c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19233210516
|
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 10, 2025
* Notes: Add keyboard support for tree navigation * Refactoring * Add e2e tests
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 8651bcf |
github-actions
bot
added
the
Backported to WP Core
Member
|
Nice work @t-hamano - this worked well in my testing. |
Mamaduka
reviewed
Nov 11, 2025
| setCanvasMinHeight, | ||
| ] ); | ||
|
|
||
| const handleThreadNavigation = useCallback( |
Member
There was a problem hiding this comment.
The memoization here is unnecessary and does nothing.
Why?
- You still passing regular callback to
onKeyDown. It will have new reference on each re-render. - The
handleThreadNavigationisn't used as dependency for other hook or passed as prop to memoized component.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, I will submit a pull request so that it can be backported before the RC1 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72958
What?
This PR adds the following keyboard navigation to improve the accessibility of Note
How?
To navigate to the adjacent note, the first note, or the last note, information about all the notes is required. Therefore, I moved the keydown event from the
Threadcomponent to the upstreamCommentscomponent.Testing Instructions
Screenshots or screencast
b0b971ebd7885f35bbe2e890c7cace85.mp4