Skip to content

Theme: disable bgramp tests to fix trunk failures #73122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tyxla merged 1 commit into from
Nov 9, 2025
Merged

Theme: disable bgramp tests to fix trunk failures #73122

tyxla merged 1 commit into from
Nov 9, 2025

Conversation

@jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Nov 9, 2025

The background ramp tests are failing mysteriously on trunk in CI. It looks like there is some difference in how floating point color calculations are done on different machines. Or does colorjs.io use some system info about supported gamuts etc? Let's disable the tests so that we don't block others while we're figuring this out.

@jsnajdr jsnajdr requested review from aduth, mirka and tyxla November 9, 2025 15:38
@jsnajdr jsnajdr self-assigned this Nov 9, 2025
@github-actions
Copy link

github-actions bot commented Nov 9, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jsnajdr jsnajdr mentioned this pull request Nov 9, 2025
Merged
@jsnajdr jsnajdr added [Type] Flaky Test Auto-generated flaky test report issue [Package] Theme /packages/theme labels Nov 9, 2025
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Flaky tests detected in 626a39d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19210704387
📝 Reported issues:

tyxla
tyxla approved these changes Nov 9, 2025
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's 🚀

@tyxla tyxla merged commit 4dc556a into trunk Nov 9, 2025
41 of 44 checks passed
@tyxla tyxla deleted the disable/theme-bgramp-tests branch November 9, 2025 16:21
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 9, 2025
@aduth aduth mentioned this pull request Dec 3, 2025
Open
@aduth
Copy link
Member

aduth commented Dec 3, 2025

Follow-up issue for re-enabling: #73726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyxla tyxla tyxla approved these changes

@mirka mirka Awaiting requested review from mirka

@aduth aduth Awaiting requested review from aduth

Assignees

@jsnajdr jsnajdr

Labels

[Package] Theme /packages/theme [Type] Flaky Test Auto-generated flaky test report issue

Projects

None yet

Milestone

Gutenberg 22.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jsnajdr @aduth @tyxla