Paragraph: Migrate to text-align block support #73111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
youknowriad
added
[Type] Enhancement
|
Size Change: +170 B (+0.01%) Total Size: 2.43 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ee74fe9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19199883956
|
26 tasks
youknowriad
force-pushed
the
migrate/paragraph-text-align
branch
from
ee74fe9 to
4a9d7c1
Compare
t-hamano
approved these changes
Nov 12, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Block transformation, block deprecation, and shortcut all work correctly.
Comment on lines
+54
to
+55
| const sourceTextAlign = | ||
| attributes.textAlign || attributes.style?.typography?.textAlign; |
Contributor
There was a problem hiding this comment.
At first glance, I thought that if the source block was a paragraph block, we should check attributes.align instead of attributes.textAlign, but it seems that the migration of the paragraph block has already been processed at this point.
Contributor
Author
|
One cool follow-up to this would be to allow "justify" but only at the global styles level. |
This was referenced Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #60763
Blocked by #62260
What
Migrates the Paragraph block to use the
textAlignblock support instead of a customalignattribute. As a consequence it also enables global styles support for textAlign for the paragraph block.Why?
The Paragraph block currently implements its own text alignment logic with a custom
alignattribute, duplicating code that should be handled by the centralizedtextAlignblock support. This migration reduces code duplication and consolidates alignment handling across blocks.How?
Replaces the custom logic with the block supports, adds deprecation and fixes transforms.
Testing Instructions