Update/twitter to x embed icon and text #73110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Twitter embed block to reflect X's rebranding: - Changed icon from Twitter bird to X logo - Updated icon color from Twitter blue (#1da1f2) to black (#000000) - Changed title from "Twitter" to "X" - Updated description from "Embed a tweet." to "Embed an X post." - Added 'x' and 'twitter' to keywords for better searchability Maintains backward compatibility by preserving internal name and twitter.com URL patterns. Fixes #55142 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
annezazu
added
[Type] Enhancement
|
Size Change: -167 B (-0.01%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
Contributor
Author
|
Of note, we didn't update the pattern because it's handled already in the embed/edit.js file and we need to wait for this larger Core issue to be solved (when X stops using a mix of domains). |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @WraithKenny. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
reviewed
Nov 8, 2025
| icon: embedTwitterIcon, | ||
| keywords: [ 'tweet', __( 'social' ) ], | ||
| description: __( 'Embed a tweet.' ), | ||
| keywords: [ 'x', 'twitter', 'tweet', __( 'social' ) ], |
Member
There was a problem hiding this comment.
A single-letter keyword can be a bit awkward. Are we good with that?
youknowriad
approved these changes
Nov 8, 2025
Contributor
|
I added the props from both PRs |
|
Flaky tests detected in 5f1acab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19200187994
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #55142
Alternative and updated PR for #65580
Updates the Twitter embed block to reflect X's rebranding with new logo, name, and messaging.
Why?
Twitter rebranded to X, and the embed block still shows outdated Twitter branding (blue bird logo and "Twitter" references). This creates confusion for users and doesn't reflect the current state of the platform.
How?
packages/block-library/src/embed/icons.jspackages/block-library/src/embed/variations.jsTesting Instructions
/command or block inserterTesting Instructions for Keyboard