Update synced pattern language from "Detach" to "Disconnect pattern" #73105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the block toolbar option from "Detach" to "Disconnect pattern" for synced patterns to improve clarity for users. The term "detach" was technically accurate but lacked clarity for both sighted and visually impaired users. Updates: - Pattern manage button component - Reusable blocks manage button component - E2E test assertions Fixes #54625 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
annezazu
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Nov 8, 2025
| } | ||
| } } | ||
| > | ||
| { __( 'Detach' ) } |
Member
There was a problem hiding this comment.
There are also some e2e tests that wil need to be updated. You can look for 'Detach there and update accordingly.
Contributor
Author
There was a problem hiding this comment.
Just updated! Can you re-review?
tyxla
requested changes
Nov 8, 2025
| // Disconnect the paragraph from the header template part. | ||
| await editor.selectBlocks( templatePartWithParagraph ); | ||
| await editor.clickBlockOptionsMenuItem( 'Detach' ); | ||
| await editor.clickBlockOptionsMenuItem( 'Disconnect pattern' ); |
Member
There was a problem hiding this comment.
Actually, this is an unrelated one, it's for converting template parts to blocks; we should revert that change
|
Flaky tests detected in 3c00f6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19197597513
|
Contributor
|
Maybe it's just me but I don't really like the "disconnect" wording. Maybe it works in English but I prefer "detach" personally or "unlink" or something like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The term "detach" was technically accurate but lacked clarity for both sighted and visually
impaired users. "Disconnect pattern" is more descriptive of the action being performed - breaking a pattern from the source. I think it's important to include "pattern" at the end here rather than just "Disconnect", especially when we already have a "Manage patterns" option. As is, it's not even clear what is being detached!
How?
Changed the label text in:
packages/patterns/src/components/patterns-manage-button.js)packages/reusable blocks/src/components/reusable-blocks-menu-items/reusable-blocks-manage-button.js)test/e2e/specs/editor/various/patterns.spec.jsTesting Instructions
Testing Instructions for Keyboard
Shift+Alt+Zor arrowkeys
Before:
After: