-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update: Use a bigger max fit text font size. #73067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +3 B (0%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: c4257b6 |


Currently fit text is limiting the max size to 600px. According to feedback from @henriqueiamarino, @iamtakashi this may not be enough to have a fit effect on some cases, so this PR increases the max size to 2400px covering a much bigger set of possibilities without having a noticeable performance impact.
Testing Instructions
Verify fit text still works.
Try Fit text with small text like "Fit" verify now the maximum font size is bigger than 600px.