DataViews: Simplify the properties config #73064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3.04 kB (-0.12%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c9b2c6c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19181084358
|
Contributor
|
I like the simplicity but this means it's no longer possible to re-order fields on non-table layouts, was that discussed? If fields are now just toggles, should we go ahead and use ToggleControl? |
Contributor
Author
Yes, briefly, the idea is that it's not a huge use-case really but potentially we could have another secondary UI for this later if there's a big demand. |
Contributor
Author
This design was suggested based on other similar patterns like the MacOS finder. |
Contributor
|
MacOS Finder uses a dedicated menu which seems a little different, the DataView appearance options UI is more like a form. I don't really see much value in a one-off design just for this UI, and would rather use an existing/familiar component. Just my 2c though, not a strong opinion. |
Contributor
Author
I'm talking about this btw. |
Contributor
Author
|
Happy to switch the design as needed assuming there's agreements. cc @mtias |
Member
|
@jameskoster what UI did you have in mind? |
Contributor
|
Just a group of toggles. Hacky mockup: 
|
Member
|
Shouldn't it be checkboxes in this case? :D |
mtias
reviewed
Nov 7, 2025
| /> | ||
| ) } | ||
| </HStack> | ||
| <Item onClick={ field.enableHiding ? onToggleVisibility : undefined }> |
Member
There was a problem hiding this comment.
We can revise later if it makes sense to extract something from dropdown menu with checkboxes, which behaves similar to this
Contributor
Author
There was a problem hiding this comment.
Yes, this feels like a shared component, basically a "multi select" component that is "open always"
Contributor
There was a problem hiding this comment.
Worth checking the code but I think there might be a partial implementation of Listbox for the filter UI:
Maybe we can extract that?
Contributor
There was a problem hiding this comment.
No idea why 'Status' is an option in the Status filter for templates. I'll open an issue about that 😪
mtias
approved these changes
Nov 7, 2025
youknowriad
force-pushed
the
update/simplify-dataviews-view-config
branch
from
6ae7a65 to
c9b2c6c
Compare
Contributor
|
@youknowriad I had the content preview option enabled for pages, now that this has merged I'm getting an error when I load the pages dataview: 
|
Contributor
Author
|
@jameskoster Mind creating an issue for this? Happy to look afterwards. My guess is that it's probably a pre-existing issue made visible by this PR as this doesn't really impact rendering. |
ntsekouras
reviewed
Nov 10, 2025
| ( f ) => | ||
| ! visibleFieldIds.includes( f.id ) && | ||
| ! togglableFields.includes( f.id ) && | ||
| f.type !== 'media' && |
Contributor
There was a problem hiding this comment.
How should we handle the featured image and content-preview fields? Right now with this check, we end up not allowing to display more than one media field. Should we just remove this check?
Another thing related to the above is that before we had a specific place for media fields and opinionated styles. If we allow more media fields, should we add some basic styles to such fields to avoid layout issues (maybe super tall images etc..)..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
We were optimizing for advanced cases at the expense of the common cases.
Testing Instructions
- Visible fields show checkmark on left
- Hidden fields show no checkmark
- Click any field to toggle visibility
- Field order remains consistent when toggling
- No arrows, no media menu, no descriptions
- At least one field must remain visible (cannot hide all)