Notes: Gracefully handle non-existing note ID references (alt) #73061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Notes
|
Size Change: -39 B (0%) Total Size: 2.47 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
I've decided that I like this solution more 😄 Marking it ready for review and testing. I'm going to keep the alt PR open just in case. |
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
Mamaduka
added
the
Backport to WP 6.9 Beta/RC
|
Flaky tests detected in 8e3cf77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19143408542
|
adamsilverstein
approved these changes
Nov 7, 2025
Member
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
Code looks good, I will give this a test.
t-hamano
approved these changes
Nov 7, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! I like this approach.
Member
Author
|
Thanks for testing, folks. Let's merge this. |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 7, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: adamsilverstein <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: desrosj <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: ac9927f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #73017.
Alternative to #73050.
Allows adding new note to a block if associated
noteIdmetadata doesn't exists or is invalid.Note: Appriciate testing edge cases, I tried my best to do it, but we all forget something.
Why?
Blocks and their attributes can be copied and pasted into different posts, where associated notes don't exist. This created a bug and prevented users from adding new notes to copied content.
How?
Make
newNoteFormState === 'open'only requirement and source of thruth to display the new note form.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast