Revert: template activation #73025
Revert: template activation #73025
Conversation
)" This reverts commit 0bf76a7.
This reverts commit ba57e12.
This reverts commit df6030f.
This reverts commit 776ca7a.
This reverts commit d0a3f84.
This reverts commit a608ced.
This reverts commit e185a04.
This reverts commit 1839787.
This reverts commit dcf8128.
…)" This reverts commit b58483e.
This reverts commit 682e7ac.
)" This reverts commit 32d3736.
|
Flaky tests detected in 1ad0abe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19121177434
|
t-hamano
added
the
[Feature] Templates API
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
For what it's worth I checked this branch against WP 6.8.3 (with the Gutenberg plugin deactivated) and the following are working identically for me:
I'll let folks more familiar with the feature make the final call, but LGTM so far.
Just a question, I'm extending the templates controller for an unrelated content only feature in #72988 Should we hold off merging that until we know what's going on in trunk? |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I'm not familiar with the implementation details, so I'd like to ask someone else to provide a more detailed review, but I'll leave one piece of feedback.
| { | ||
| "$schema": "./schemas/json/wp-env.json", | ||
| "core": "WordPress/WordPress", | ||
| "core": "WordPress/WordPress#6.8.3", |
There was a problem hiding this comment.
This change is unnecessary?
There was a problem hiding this comment.
I see this justification in the PR description:
We have to set the env WP version to 6.8 instead of trunk so the tests pass. When we revert the changes in core, we can restore it to trunk again.
|
Not sure how it should be handled, but I see that I now have duplicate and misbehaving templates due to changes I made while this feature was live. 
First sign was this classic console warning:
The respective records (as returned by 
|
|
@mcsf That's fine I think, it's something that we should think about if we want to revert it in GB trunk as well, but for the |
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
I cannot thoroughly vet this, but the commit list is clear and the functionality seems back to what it was. :)
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
|
Whoops, forgot the props. I will give you all props on the WP core PR :) |
This commit reverts the PHP changes that were made to support the template activation feature. The UI was already reverted through the packages sync in [61177] (Gutenberg PR: WordPress/gutenberg#73025). Developed in #10473. Fixes #64214. Props ellatrix, t-hamano, mcsf, ramonjd. git-svn-id: https://develop.svn.wordpress.org/trunk@61178 602fd350-edb4-49c9-b593-d223f7449a82
This commit reverts the PHP changes that were made to support the template activation feature. The UI was already reverted through the packages sync in [61177] (Gutenberg PR: WordPress/gutenberg#73025). Developed in WordPress/wordpress-develop#10473. Fixes #64214. Props ellatrix, t-hamano, mcsf, ramonjd. Built from https://develop.svn.wordpress.org/trunk@61178 git-svn-id: https://core.svn.wordpress.org/trunk@60514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit reverts the PHP changes that were made to support the template activation feature. The UI was already reverted through the packages sync in [61177] (Gutenberg PR: WordPress/gutenberg#73025). Developed in WordPress/wordpress-develop#10473. Fixes #64214. Props ellatrix, t-hamano, mcsf, ramonjd. Built from https://develop.svn.wordpress.org/trunk@61178 git-svn-id: http://core.svn.wordpress.org/trunk@60514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What?
This reverts template activation on the
wp/6.9first, we'll see if we can improve trunk or revert there as well.Why?
After feedback and review with multiple Gutenberg contributors, we decided to delay this to 7.0.
How?
We have to set the env WP version to 6.8 instead of trunk so the tests pass. When we revert the changes in core, we can restore it to trunk again.
Testing Instructions
Everything should work as before in 6.8.
Testing Instructions for Keyboard
Screenshots or screencast