Fix: Fit text may not update when being grouped in a smaller container. #73021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ellatrix and
tellthemachines
as code owners
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
t-hamano
added
the
Backport to WP 6.9 Beta/RC
jorgefilipecosta
force-pushed
the
fix/fit-text-recompute-on-group
branch
from
62e5109 to
10f1c16
Compare
|
Flaky tests detected in fe069c4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19135514624
|
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 6, 2025
…r. (#73021) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: saarnilauri <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 636c4ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #72963
Currently there is a bug where when a fit text block is grouped inside a smaller container it may not update right away.
This PR fixes the issue by monitoring changes of the parent and observing its dimensions and not only the parent.
cc: @saarnilauri
Testing Instructions
Add a fit text paragraph with some text.
Group it inside a group block.
Set the group content width to 50%, verify fit text fits.
Change the content width to 66% verify it continues to fit.
Verify things also look good on the front end.