Remove some modal subscriptions when inactive#73014
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
changed the title
9 tasks
|
Size Change: -22 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7999691. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19106406944
|
scruffian
approved these changes
Nov 11, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
One question, but I think this is good to merge.
| const [ isModalOpen, setIsModalOpen ] = useState( | ||
| () => isNewPost && postType === 'wp_block' | ||
| const isNewPost = useSelect( | ||
| ( select ) => select( editorStore ).isCleanNewPost(), |
Contributor
There was a problem hiding this comment.
Is it worth moving this to packages/edit-post/src/components/layout/index.js as well, so that this component has no subscriptions?
Contributor
Author
There was a problem hiding this comment.
No, it's actually better not to, as this component will only mount when you're editing a wp_block type, which is fairly rare. So, moving isCleanNewPost up would mean it would run more often, unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes subscriptions from modals that are not active, and cannot be active in their given scenario.
Why?
Minor perf. Reduce subscriptions if easy and sensible.
How?
Modals don't need to be subscribed to changes when inactive. They only need the information when they are open. Don't subscribe to the store if the modal isn't active or won't be rendered in that context.
Testing Instructions
Generated by Claude AI
Test that the modal appears correctly:
Test that the modal doesn't mount unnecessarily:
Test the rename functionality:
Test the duplicate functionality:
Testing Instructions for Keyboard
Screenshots or screencast