Notes: Fix selector for orderedBlockIds #73006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.9 Editor Tasks
|
Size Change: +6 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Nov 5, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the fix! This PR is working very well 👍
f616afc40c78805110be051eca43b1db.mp4
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ef00908. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19102060746
|
|
I have tested this PR in playground and its working well. 
|
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.9 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: Dhruval-678 <[email protected]> Co-authored-by: jeffpaul <[email protected]> Co-authored-by: karthick-murugan <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 6b50f4f |
Member
|
Nice one @Mamaduka! |
Member
|
Really great work helping triage this in a detailed manner @karthick-murugan and fantastic expedited resolution @Mamaduka, yall are doing some really lovely work ensuring the overall Notes experience lands as smoothly as possible in 6.9! |
Member
|
Noting that we may need to use the Core Props tool in Make Core admin to adjust the backport so that it also credits https://profiles.wordpress.org/dhruvang21/ from the origin report and their testing on Trac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #72896.
PR fixes block cliend ID order used for floating notes and new form positions to handle nested blocks correctly. Replaces
getBlockOrderwithgetClientIdsWithDescendants. ThegetBlockOrdermethod defaults to returning only top-level blocks for the root content or the specified block.We're also using same selector in the
useBlockCommentshook.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast