Notes: Disable "Add note" button in Distraction free mode #72954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
6 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +42 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 651a162. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19055503794
|
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 4, 2025
* Revert "Hide add note in distraction free mode (#72835)" This reverts commit a2f779c. * Notes: Disable "Add note" button in Distraction free mode Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jeffpaul <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 9bfab24 |
Contributor
|
The only thing I'd say is, it would be nice to avoid the typographic widow. Not a blocker, but a small enhancement would be to add |
Member
+1. However, that's more of a general issue with the Dropdown component, and hopefully, something that will be resolved when it's refactored with new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72945
What? Why?
In #72945, we have completely disabled the Notes feature in DFM mode. As a more friendly approach, this pull request displays a disabled "Add note" button with help text to indicate why the Notes feature is disabled.
How?
In DFM mode, only the "Add note" button in the toolbar drop-down menu is visually restored. The following three buttons remain hidden:
Testing Instructions
Screenshots or screencast