Theme: Fix Windows build using cross-env for environment variables #72944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +116 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
dream-encode
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Validated the cross-env fix. npm run build failed as expected prior, then succeeded when this PR was applied.
Thanks @aduth!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue where the theme package can't be built on Windows.
Example: https://github.com/WordPress/wordpress-develop/actions/runs/19047308051/job/54400032675
Related Slack discussion: https://wordpress.slack.com/archives/C02RQBWTW/p1762200484307419
Error:
Why?
wordpress-developbuildHow?
Uses
cross-envpackage to define environment variables. We use the package elsewhere in the project for the same purpose.Testing Instructions
Ensure that the build script finishes successfully, with no errors or local changes to your working branch:
Ideally you'd also test this on a Windows machine if you have one available.