Testing: Enable no-unused-disable ESLint Comments plugin rule #72940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
DAreRodz,
ObliviousHarmony,
ZebulanStanphill,
ajitbohra,
ellatrix,
fabiankaegy,
getdave,
luisherranz,
nerrad,
ntwb,
swissspidy,
t-hamano and
tellthemachines
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 2.45 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
Nov 3, 2025
|
Flaky tests detected in ef8fe11. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19073080515
|
manzoorwanijk
approved these changes
Nov 4, 2025
Member
manzoorwanijk
left a comment
manzoorwanijk
left a comment
There was a problem hiding this comment.
Thank you. I love these clean ups.
These files are auto-generated, and expected to have some formatting issues. However, blanket disabling Prettier is incompatible with no-unused-disable because some of the files are fine as-is. A better long-term solution would be to apply Prettier to the generated output, similar to what's done in `packages/theme` for Theme artifacts.
aduth
force-pushed
the
remove/eslint-unused-disable
branch
from
1e2ff55 to
486780a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates project ESLint configuration to enable
eslint-comments/no-unused-disable.Why?
Unused disables are ineffective and misleading technical debt.
We already have ESLint rules around best practices for ESLint comments, so this is a reasonable rule to enable.
How?
Enables the rule. We already have the plugin, but it's not part of the "recommended" preset.
Testing Instructions
npm run lint:jsshould pass.