i18n: Use _x() for Template Activation labels #72928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
mcsf
commented
Nov 3, 2025
| const activeLabel = item._isCustom | ||
| ? __( 'Active when used' ) | ||
| : __( 'Active' ); | ||
| ? _x( 'Active when used', 'template' ) |
Contributor
Author
There was a problem hiding this comment.
Beyond the scope of this PR, but I wonder if this one could use a tooltip for the user. It might also be a little confusing for translators.
For both audiences, it could read as tautological.
Member
There was a problem hiding this comment.
I think this might help, but I don't think it's a requirement in the context of where it appears.
Agreed this is beyond the scope of the PR in any case.
tyxla
approved these changes
Nov 3, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Thanks for following up, LGTM 🚀
| const activeLabel = item._isCustom | ||
| ? __( 'Active when used' ) | ||
| : __( 'Active' ); | ||
| ? _x( 'Active when used', 'template' ) |
Member
There was a problem hiding this comment.
I think this might help, but I don't think it's a requirement in the context of where it appears.
Agreed this is beyond the scope of the PR in any case.
mcsf
added
the
Backport to WP 6.9 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 3, 2025
Co-authored-by: mcsf <[email protected]> Co-authored-by: tyxla <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 70acfc7 |
github-actions
bot
added
the
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up of #72713, per @tyxla's feedback
Uses i18n's
_x()function instead of__()to pass translation context to the following labels used in the Template Editor's items' Status field:Why?
Avoid ambiguities, mitigate locale-specific grammatical agreement issues, etc.