Skip to content

Conversation

@oandregal
Copy link
Member

Follow-up to #72417

What?

Changes the styles of the primary action in list layout.

6.8 6.9 (current trunk) This PR
Screenshot 2025-10-29 at 10 20 47 Screenshot 2025-10-29 at 10 20 55 Screenshot 2025-11-03 at 10 42 24

How?

Removes the "small" and "link" props from the button.

Testing Instructions

Visit the site editor, switch to any list layout (e.g., in the Pages screen) and verify the styles.

@oandregal oandregal self-assigned this Nov 3, 2025
@oandregal oandregal added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 3, 2025
@jameskoster
Copy link
Contributor

The broken alignment is quite strange. Maybe we just remove the link prop for now?

Separately it would probably make sense to update the small variant to use the same type styles as other buttons.

@oandregal
Copy link
Member Author

Switched back to small: the click target looks too small, but perhaps it's fine given the padding around.

For comparison:

Small Default
Screenshot 2025-11-03 at 11 36 01 Screenshot 2025-11-03 at 10 42 24

@oandregal oandregal marked this pull request as ready for review November 3, 2025 10:40
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>
Co-authored-by: jameskoster <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Flaky tests detected in 6467625.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19031709758
📝 Reported issues:

@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Nov 4, 2025
@oandregal oandregal added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 4, 2025
@jameskoster
Copy link
Contributor

I think the target is bigger than the previous icon-based approach, so it should be okay.

@oandregal
Copy link
Member Author

oandregal commented Nov 5, 2025

@jameskoster sounds good. Do you think this is ready to merge and backport to 6.9? I feel this is better than what we have now in 6.9.

@jameskoster
Copy link
Contributor

Yep, agree it's an improvement.

@oandregal oandregal merged commit 5a80556 into trunk Nov 5, 2025
40 checks passed
@oandregal oandregal deleted the update/list-primary-action branch November 5, 2025 13:05
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Nov 5, 2025
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch.

PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk.

# Checkout the wp/6.9 branch instead of trunk.
git checkout wp/6.9

# Create a new branch for your PR.
git checkout -b my-branch

# Cherry-pick the commit.
git cherry-pick 5a80556d21ee9e21758ed53e9855164895dca459

# Check which files have conflicts.
git status

# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue

# Push the branch to the repository
git push origin my-branch

# Create a PR and set the base to the wp/6.9 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

@oandregal
Copy link
Member Author

oandregal commented Nov 5, 2025

Manual backport PR at #73009 (there was a changelog conflict)

t-hamano added a commit that referenced this pull request Nov 5, 2025
@t-hamano t-hamano removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 5, 2025
@t-hamano t-hamano added the Backported to WP Core Pull request that has been successfully merged into WP Core label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants