-
Notifications
You must be signed in to change notification settings - Fork 4.6k
DataViews list layout: use regular button for primary action #72920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The broken alignment is quite strange. Maybe we just remove the Separately it would probably make sense to update the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 6467625. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19031709758
|
|
I think the target is bigger than the previous icon-based approach, so it should be okay. |
|
@jameskoster sounds good. Do you think this is ready to merge and backport to 6.9? I feel this is better than what we have now in 6.9. |
|
Yep, agree it's an improvement. |
|
There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch. PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk. |
Co-authored-by: oandregal <[email protected]> Co-authored-by: jameskoster <[email protected]>
|
Manual backport PR at #73009 (there was a changelog conflict) |
…#73009) Co-authored-by: jameskoster <[email protected]> Co-authored-by: oandregal <[email protected]> Co-authored-by: t-hamano <[email protected]>


Follow-up to #72417
What?
Changes the styles of the primary action in list layout.
How?
Removes the "small" and "link" props from the button.
Testing Instructions
Visit the site editor, switch to any list layout (e.g., in the Pages screen) and verify the styles.