Math: Fixing Edit as HTML feature and code editor sync #72910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
SirLouen
requested review from
DAreRodz,
ObliviousHarmony,
ZebulanStanphill,
getdave,
luisherranz,
nerrad,
ntwb,
oandregal,
spacedmonkey,
swissspidy,
t-hamano and
tellthemachines
as code owners
SirLouen
removed request for
ajitbohra,
getdave,
juanmaguitar,
nerrad,
ntwb,
oandregal,
spacedmonkey and
swissspidy
SirLouen
requested review from
ntsekouras
and removed request for
DAreRodz,
ZebulanStanphill,
fabiankaegy and
tellthemachines
SirLouen
force-pushed
the
patch/72899
branch
5 times, most recently
from
a85f0ae to
a65ceb5
Compare
t-hamano
added
the
Backport to WP 6.9 Beta/RC
|
There was a conflict while trying to cherry-pick the commit to the wp/6.9 branch. Please resolve the conflict manually and create a PR to the wp/6.9 branch. PRs to wp/6.9 are similar to PRs to trunk, but you should base your PR on the wp/6.9 branch instead of trunk. |
Contributor
|
@SirLouen, the automatic cherry-pick to the See: #72910 (comment) |
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Nov 5, 2025
* Math: Fixing Edit as HTML feature and code editor sync * fix: More syntantical uniformity * fix: Add support indication for core/math block in documentation Co-authored-by: SirLouen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: shimotmk <[email protected]>
SirLouen
added a commit
to SirLouen/gutenberg
that referenced
this pull request
Nov 5, 2025
* Math: Fixing Edit as HTML feature and code editor sync * fix: More syntantical uniformity * fix: Add support indication for core/math block in documentation Co-authored-by: SirLouen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: shimotmk <[email protected]>
Member
Author
|
Ok I sorted it #73003 |
t-hamano
added a commit
that referenced
this pull request
Nov 5, 2025
* Math: Fixing Edit as HTML feature and code editor sync * fix: More syntantical uniformity * fix: Add support indication for core/math block in documentation Co-authored-by: SirLouen <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: shimotmk <[email protected]>
Contributor
|
This pull request was manually cherry-picked into the |
t-hamano
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #72899
The Math component should not have Edit as HTML, as the whole Component is managed through attributes. Changes in the HTML won't reflect on the component. Also, little improvements as we can already destructure
latex, we can also destructuremathMLWhy?
According to #72899, while editing as HTML, there is a visual glitch on the textarea. The solution could be removing such textarea, but in reality the true solution is completely removing the HTML editing feature.
How?
Removing the supports