-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Math format: Force LTR direction in RTL languages #72901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @muajjiin, @okawayasuno. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @okawayasuno! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It's working as expected, but the changes to the package-lock.json file were unnecessary, so I reverted those changes in 427cf03.
Thank you for your first contribution!
|
Congratulations on your first merged pull request, @okawayasuno! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: And if you don't have a WordPress.org account, you can create one on this page: Kudos! |
* fix rtl * Revert unnecessary changes made to package-lock.json --------- Unlinked contributors: [email protected], muajjiin, okawayasuno. Co-authored-by: t-hamano <[email protected]> Co-authored-by: harshbhonsle <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 8c1e5d1 |
What?
Closes #72553
When text is RTL, change the CSS for Math format input to
direction: ltr;Why?
To fix the issue
Testing Instructions
Use inline mass formatting
Set the site's language to an RTL language
Testing Instructions for Keyboard
Screenshots or screencast