Skip to content

Conversation

@okawayasuno
Copy link
Contributor

What?

Closes #72553

When text is RTL, change the CSS for Math format input to direction: ltr;

Why?

To fix the issue

Testing Instructions

Use inline mass formatting
Set the site's language to an RTL language

Testing Instructions for Keyboard

Screenshots or screencast

スクリーンショット 2025-11-01 17 58 05
Before After

@okawayasuno okawayasuno requested a review from ellatrix as a code owner November 1, 2025 08:58
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected], @muajjiin, @okawayasuno.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected], muajjiin, okawayasuno.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: harshbhonsle <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @okawayasuno! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 1, 2025
@t-hamano t-hamano changed the title fix rtl Math format: Force LTR direction in RTL languages Nov 1, 2025
@t-hamano t-hamano added Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Format library /packages/format-library Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Type] Bug An existing feature does not function as intended labels Nov 1, 2025
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's working as expected, but the changes to the package-lock.json file were unnecessary, so I reverted those changes in 427cf03.

Thank you for your first contribution!

@t-hamano t-hamano merged commit b41c908 into WordPress:trunk Nov 1, 2025
53 of 57 checks passed
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

Congratulations on your first merged pull request, @okawayasuno! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 1, 2025
@github-actions github-actions bot removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 1, 2025
gutenbergplugin pushed a commit that referenced this pull request Nov 1, 2025
* fix rtl

* Revert unnecessary changes made to package-lock.json

---------

Unlinked contributors: [email protected], muajjiin, okawayasuno.

Co-authored-by: t-hamano <[email protected]>
Co-authored-by: harshbhonsle <[email protected]>
@github-actions github-actions bot added the Backported to WP Core Pull request that has been successfully merged into WP Core label Nov 1, 2025
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 8c1e5d1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Math Block and Math format: Force LTR direction in RTL languages

2 participants