-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Notes: Disable or hide "Add note" button depending on block’s state #72878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Change: +113 B (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
packages/editor/src/components/collab-sidebar/comment-menu-item.js
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing.
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @t-hamano! The code looks good to me.
…72878) * Notes: Disable or hide "Add note" button depending on block’s state. * Update info text * Move logic info the editor package Co-authored-by: t-hamano <[email protected]> Co-authored-by: jeffpaul <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: shimotmk <[email protected]>
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 29b27cf |
Closes #72520
What?
This pull request hides or disables the "Add note" button in blocks where the Note feature is not available:
How?
Testing Instructions
Use the following HTML to insert to test the Unsupported block, broken block, and Classic block:
Screenshots or screencast
Classic Block dropdown menu