Notes: spotlight block when clicking add/view notes #72870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Oct 31, 2025
Comment on lines
+50
to
+54
| const unselectThread = () => { | ||
| setShowCommentBoard( false ); | ||
| blockElement?.focus(); | ||
| toggleBlockSpotlight( clientId, false ); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This is the process that occurs when adding a new note is canceled. The process for removing the spotlight state was missing.
Member
There was a problem hiding this comment.
I think we also want to disable spotlight and call toggleBlockSpotlight onBlur event as well, since we're also closing the form on that event.
Contributor
Author
There was a problem hiding this comment.
Nice catch! Fixed in eabafcd
5abd98c700cdf4218eae89bff3f9b995.mp4
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +18 B (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 31, 2025
github-actions
bot
removed
the
Backport to WP 6.9 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 31, 2025
* Notes: spotlight block when clicking add/view notes * Disable spotlight on blur Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: desrosj <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: 94e708d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72861
What?
This PR spotlights (makes all blocks except the selected one semi-transparent) the block when the "View notes" or "Add notes" button is clicked.
Why?
To match the visual effect when a note is clicked directly. The block should be spotlighted when the note is opened and focused.
Testing Instructions
Add note
View note
Screenshots or screencast
d94a31c6591e1b7d2387ea7074b77f9f.mp4