Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Oct 31, 2025

What?

This PR adds min-height to the textarea element of TextareaControl.

Why?

To avoid the textarea element looking bad if height was resized to the lowest possible point.

This was influenced by this real-life example.

How?

Just adding a calculated min-height.

Testing Instructions

  • Load Storybook
  • Go to TextareaControl
  • Resize height down and verify it looks good.

Testing Instructions for Keyboard

Same

Screenshots or screencast

Before:

Screen.Recording.2025-10-31.at.11.41.35.mov

After:

Screen.Recording.2025-10-31.at.11.41.03.mov

@tyxla tyxla requested review from a team, ellatrix and ntsekouras October 31, 2025 09:50
@tyxla tyxla self-assigned this Oct 31, 2025
@tyxla tyxla requested a review from ajitbohra as a code owner October 31, 2025 09:50
@tyxla tyxla added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Oct 31, 2025
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Flaky tests detected in 2f92f83.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18969500284
📝 Reported issues:

@tyxla tyxla merged commit bc038f2 into trunk Oct 31, 2025
34 checks passed
@tyxla tyxla deleted the add/textarea-control-min-height branch October 31, 2025 11:07
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants