Skip to content

DataViews: Update actions menu structure to group primary and regular actions #72866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntsekouras merged 7 commits into from
Nov 5, 2025
Merged

DataViews: Update actions menu structure to group primary and regular actions #72866

ntsekouras merged 7 commits into from
Nov 5, 2025

Conversation

@hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented Oct 31, 2025

What?

Closes #72840

Why?

  • To group primary and regular actions in DataViews table, list and grid.

How?

  • Group all primary actions at the top of the menu.
  • Introduce a divider between primary and regular actions.

Testing Instructions

  1. Checkout to PR branch.
  2. Open the site editor.
  3. Go to DataViews, and check the actions.
  4. The actions would be grouped together and would have a separator line.

Testing Instructions for Keyboard

  • None

Screenshots or screencast

Before After
Screenshot 2025-10-31 at 3 06 00 PM Screenshot 2025-10-31 at 3 05 37 PM

@hbhalodia hbhalodia requested a review from oandregal as a code owner October 31, 2025 09:37
@hbhalodia hbhalodia self-assigned this Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: sidharthpandita1 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia mentioned this pull request Oct 31, 2025
Closed
@hbhalodia hbhalodia mentioned this pull request Oct 31, 2025
Open
ntsekouras
ntsekouras reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM, but I'd appreciate a quick look from @oandregal, since it's been a while I worked on this part.

@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 3, 2025
@hbhalodia hbhalodia requested a review from ntsekouras November 4, 2025 08:50
@jameskoster
Copy link
Contributor

jameskoster commented Nov 5, 2025

Thanks! Looks good to me.

Down the road I think we might want to consider an additional isDestructive flag for actions, to position things like 'Move to trash' at the bottom of the menu, even when primary. Fine to tackle that separately though.

ntsekouras
ntsekouras approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ntsekouras ntsekouras merged commit 6e6da73 into WordPress:trunk Nov 5, 2025
34 checks passed
@github-actions github-actions bot added this to the Gutenberg 22.1 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@oandregal oandregal Awaiting requested review from oandregal oandregal is a code owner

@jameskoster jameskoster Awaiting requested review from jameskoster

Assignees

@hbhalodia hbhalodia

Labels

[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 22.1

Development

Successfully merging this pull request may close these issues.

DataViews: Update actions menu structure

3 participants

@hbhalodia @jameskoster @ntsekouras