Skip to content

Shortcut keys for Notes submit #72864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karthick-murugan wants to merge 1 commit into from
Closed

Shortcut keys for Notes submit #72864

karthick-murugan wants to merge 1 commit into from

Conversation

@karthick-murugan
Copy link
Contributor

@karthick-murugan karthick-murugan commented Oct 31, 2025 •
edited
Loading

What?

Closes #72721

This PR adds keyboard shortcut support for submitting notes and note replies in the collaboration sidebar. Users can now submit notes by pressing ⌘ + Enter (Mac) or Ctrl + Enter (Windows/Linux), which aligns with common patterns in many modern applications.

Why?

Many apps let users submit forms using ⌘ + Enter or Ctrl + Enter, offering a faster, familiar workflow. Currently, users must click the submit button to post notes or replies, which slows them down. Adding keyboard submission improves efficiency and aligns with user expectations from platforms like GitHub, Slack, and Discord.

Testing Instructions

  1. Open a post or page in the WordPress editor
  2. Enable the collaboration/notes feature if needed
  3. Select a block and click to add a new note, or reply to an existing note
  4. Type some text in the note/reply textarea
  5. Press ⌘ + Enter (Mac) or Ctrl + Enter (Windows/Linux)
  6. Verify that the note/reply is submitted successfully
  7. Try the keyboard shortcut when the textarea is empty or contains only whitespace - it should not submit (respects disabled state)
  8. Verify that clicking the submit button still works as before

Video

REC-20251031141637.mp4

@karthick-murugan karthick-murugan marked this pull request as ready for review October 31, 2025 08:48
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: desrosj <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka mentioned this pull request Oct 31, 2025
Merged
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting labels Oct 31, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Oct 31, 2025

I went with a slightly different direction - #72868.

@karthick-murugan
Copy link
Contributor Author

karthick-murugan commented Oct 31, 2025

I went with a slightly different direction - #72868.

Shall I close this PR?

@t-hamano
Copy link
Contributor

t-hamano commented Oct 31, 2025

Since #72868 also includes E2E tests, let's proceed with #72868.

@karthick-murugan Thanks for your efforts!

@t-hamano t-hamano closed this Oct 31, 2025
@karthick-murugan karthick-murugan deleted the notes-shortcut-keys branch October 31, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow notes and note replies to be submitted with ⌘ + enter

3 participants

@karthick-murugan @Mamaduka @t-hamano