Breadcrumbs: Add home page handling and show last item attribute
#72839
+77
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
jasmussen,
jorgefilipecosta,
justintadlock and
mcsf
ntsekouras
requested review from
ajitbohra,
fabiankaegy and
juanmaguitar
as code owners
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +158 B (+0.01%) Total Size: 2.45 MB
ℹ️ View Unchanged
|
Contributor
|
Seems valid enough. "Display breadcrumbs on the site front page and blog posts index" help text reads sligthly roundabout. If we're referring to the template types on which it will show, we should probably refer to those directly. Something like (but please correct me if I get this wrong):
|
Contributor
Author
@jasmussen after thinking about it more, I'm not sure we should mention templates because there can be cases a user assigns a specific page for his home page and Maybe the best path forward is the reduction of the message like the label does I think it's fine to refine text in follow ups too, but for me it's more important for this PR to explore or validate the initial design and/or placement of these settings. Is it fine to start with them under advanced like this PR or we should explore something different? |
Contributor
|
I like the simple "Show on home page", with no help text. 👍 👍 |
ntsekouras
force-pushed
the
breadcrumbs/add-home-page-handling
branch
from
a5a624d to
7c7a486
Compare
|
Flaky tests detected in 6a44a60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19031229602
|
tyxla
reviewed
Oct 31, 2025
tyxla
reviewed
Oct 31, 2025
ntsekouras
force-pushed
the
breadcrumbs/add-home-page-handling
branch
from
e6722c4 to
146e62d
Compare
ntsekouras
force-pushed
the
breadcrumbs/add-home-page-handling
branch
from
146e62d to
6a44a60
Compare
tyxla
approved these changes
Nov 3, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looking good from my perspective 👍 Thanks!
tyxla
reviewed
Nov 3, 2025
| if ( $is_home_or_front_page ) { | ||
| $breadcrumb_items[] = sprintf( | ||
| '<span aria-current="page">%s</span>', | ||
| esc_html__( 'Home' ) |
Member
There was a problem hiding this comment.
I guess we might want to land this after #72873 to reflect the escaping changes
Contributor
Author
There was a problem hiding this comment.
I'll have conflicts either way, so I'll land and rebase the other now.
Contributor
Author
There was a problem hiding this comment.
I rebased and it seems fine. I'll merge tomorrow in case you do want to take another look at that PR. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #72498 and #72649
This PR does a couple of things:
is_home() && is_paged()it also shows the page trail. This setting is only useful when the user would want to have a single breadcrumbs block in the site header and is similar toPrefer taxonomy termssetting. That's the reason I've added it underadvanced. We could leave it there or we could consider a different design for showing/editing these two attributes. --cc @jasmussenTesting Instructions
show last itemattributeonein reading settings.Screenshots or screencast