Breadcrumbs: Add `archive` link if enabled in posts #72832

ntsekouras · 2025-10-30T11:56:33Z

What?

Part of: #72498

This PR adds the archive link if enabled in posts, as it seems like a good default to have for the breadcrumbs.

Testing Instructions

Enable GB experimental blocks.
For easier testing I'm adding this plugin and the core block in theme's header and test various pages in the front end.
Test with custom post types with has_archive enabled and disabled.

Screenshots or screencast

Below I'm sharing some screenshots in a site that I've added @justintadlock's plugin and the core block in the main header.
Above is x3p0-breadcrumbs/ and below is the core block.

CPT with terms

CPT without terms

Hierarchical CPT with ancestors

packages/block-library/src/breadcrumbs/index.php

github-actions · 2025-10-31T08:38:58Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: mcsf <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

packages/block-library/src/breadcrumbs/index.php

tyxla · 2025-10-31T08:57:34Z

packages/block-library/src/breadcrumbs/index.php

 * @return array Array of breadcrumb HTML items.
 */
-function block_core_breadcrumbs_get_hierarchical_post_type_breadcrumbs( $post_id ) {
+function block_core_breadcrumbs_get_hierarchical_post_type_breadcrumbs( $post_id, $post_type ) {


It feels non-ergonomic that we also have to pass the post type explicitly. I'd rather grab it from the $post_id:

$post_type = get_post_type( $post_id );

In theory, it should be free to do that since the post object is already in the WP_Query.

From one hand you're probably right because this block doesn't make much sense in blocks that update the block context manually (like Query Loop). On the other hand though why call another function (get_post_type) when we already have the info?

I would agree if we had it inline, or if we didn't have it loaded from the database. But it should already be loaded, and we don't have it inline in that function either - we pass it between functions, and to do so we need to add an extra argument. This makes it less ergonomic, which is something to cosnider when designing functions and APIs.

That being said, I don't feel strongly about it, I don't think it's a major deal.

github-actions · 2025-10-31T10:12:22Z

Flaky tests detected in 4869547.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19099291596
📝 Reported issues:

[Flaky Test] ensures List View global shortcut works properly #51533 in /test/e2e/specs/editor/various/list-view.spec.js

packages/block-library/src/breadcrumbs/index.php

mcsf

Looks good, thanks for accommodating!

There's just one thing that should be quickly addressable before merging:

Displaying both "Home" and "Post Archives" is weird, because they both point to /. I'm not sure what the best default would be for most users: to only keep the former or only the latter. For me I'd say only keep "Home".

There's another discussion, but probably best left for subsequent PRs: would most users prefer it if we defaulted to not showing the Post Archives item when it refers to the 'post' post type?

packages/block-library/src/breadcrumbs/index.php

ntsekouras · 2025-11-19T09:43:30Z

Displaying both "Home" and "Post Archives" is weird, because they both point to /. I'm not sure what the best default would be for most users: to only keep the former or only the latter. For me I'd say only keep "Home".

I'd say the same, I'll create a follow up PR for this.

tyxla · 2025-11-19T11:22:42Z

Displaying both "Home" and "Post Archives" is weird, because they both point to /. I'm not sure what the best default would be for most users: to only keep the former or only the latter. For me I'd say only keep "Home".

I'd say the same, I'll create a follow up PR for this.

Why do we have "Post Archives" for the post post type? AFAIK has_archive is false for the post post type. Maybe if someone tinkered with the register_post_type_args or the similar filters, we could check if the has_archive is true and determine whether to display that item that way (potentially with an extra URL check, ensuring it's not the same URL as home_url( '/' ))?

ntsekouras · 2025-11-19T14:41:20Z

Why do we have "Post Archives" for the post post type?

Because we use get_post_type_archive_link and has extra logic for post and page.

After that special handling the has_archive is checked. So the only thing needed is to add the check with home_url in conjunction with show home attribute.

ntsekouras requested review from jorgefilipecosta, justintadlock, mcsf and t-hamano October 30, 2025 11:56

ntsekouras self-assigned this Oct 30, 2025

ntsekouras requested review from ajitbohra and fabiankaegy as code owners October 30, 2025 11:56

ntsekouras added [Type] Enhancement A suggestion for improvement. [Block] Breadcrumbs (experimental) Affects the Breadcrumbs Block labels Oct 30, 2025

ntsekouras mentioned this pull request Oct 30, 2025

Breadcrumbs Block: Handling Various Use Cases #72498

Open

tyxla reviewed Oct 31, 2025

View reviewed changes

packages/block-library/src/breadcrumbs/index.php Outdated Show resolved Hide resolved

tyxla reviewed Oct 31, 2025

View reviewed changes

packages/block-library/src/breadcrumbs/index.php Outdated Show resolved Hide resolved

tyxla reviewed Oct 31, 2025

View reviewed changes

ntsekouras force-pushed the breadcrumbs/add-archive-link-if-enabled-in-posts branch from 5cac11c to 2b42e7f Compare November 5, 2025 10:35

ntsekouras mentioned this pull request Nov 14, 2025

Breadcrumbs: Add filter for preferred taxonomy and term per post type #73283

Merged

ntsekouras force-pushed the breadcrumbs/add-archive-link-if-enabled-in-posts branch from 4869547 to 36fd1fa Compare November 17, 2025 07:21

mcsf reviewed Nov 17, 2025

View reviewed changes

packages/block-library/src/breadcrumbs/index.php Outdated Show resolved Hide resolved

packages/block-library/src/breadcrumbs/index.php Outdated Show resolved Hide resolved

ntsekouras force-pushed the breadcrumbs/add-archive-link-if-enabled-in-posts branch 2 times, most recently from 04253f0 to 556af36 Compare November 17, 2025 13:32

mcsf approved these changes Nov 19, 2025

View reviewed changes

packages/block-library/src/breadcrumbs/index.php Outdated Show resolved Hide resolved

ntsekouras added 8 commits November 19, 2025 11:33

Breadcrumbs: Add archive link if enabled in posts

da0cecf

feedback

52e29ae

use block_core_breadcrumbs_create_link

eafd9c8

use archives label

a0ff95c

change since

855acac

feedback

e22d4a4

build html from breadcrumbs structure

6f73c5e

feedback

1ba0014

ntsekouras force-pushed the breadcrumbs/add-archive-link-if-enabled-in-posts branch from 3b0734f to 1ba0014 Compare November 19, 2025 09:39

ntsekouras enabled auto-merge (squash) November 19, 2025 09:44

ntsekouras merged commit 2360184 into trunk Nov 19, 2025
33 of 34 checks passed

ntsekouras deleted the breadcrumbs/add-archive-link-if-enabled-in-posts branch November 19, 2025 11:00

github-actions bot added this to the Gutenberg 22.2 milestone Nov 19, 2025

ntsekouras mentioned this pull request Nov 19, 2025

Breadcrumbs: Add post type archive link if it's not the same as home url #73435

Merged

Breadcrumbs: Add archive link if enabled in posts #72832

Breadcrumbs: Add archive link if enabled in posts #72832

Uh oh!

Conversation

ntsekouras commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Testing Instructions

Screenshots or screencast

CPT with terms

CPT without terms

Hierarchical CPT with ancestors

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tyxla Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

ntsekouras Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

tyxla Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcsf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ntsekouras commented Nov 19, 2025

Uh oh!

Uh oh!

tyxla commented Nov 19, 2025

Uh oh!

ntsekouras commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Breadcrumbs: Add `archive` link if enabled in posts #72832

Breadcrumbs: Add `archive` link if enabled in posts #72832

ntsekouras commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 31, 2025 •

edited

Loading

github-actions bot commented Oct 31, 2025 •

edited

Loading